Open
Conversation
Collaborator
Author
|
Combined/Refined deaths are superseded in BYOC. Needs further modifications. |
delete process_lookup_deaths and move functionality to join_deaths_data in create_episode_file
…ce-linkage-files into refactor-nrs
lizihao-anu
commented
Apr 8, 2026
R/join_deaths_data.R
Outdated
| slf_deaths_lookup = read_file(get_slf_deaths_lookup_path(year)) | ||
| BYOC_MODE = FALSE | ||
| ) { | ||
| slf_deaths_lookup = read_file(get_combined_slf_deaths_lookup_path(BYOC_MODE = BYOC_MODE)) %>% |
Collaborator
Author
There was a problem hiding this comment.
When in the episode file, I wonder whether we read files from Denodo intermediate path, or Denodo view as the files in Denodo intermediate drive will be ingested by Denodo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor NRS
read_extract_nrs_deaths(),process_extract_nrs_deaths(),process_refined_death().TODO: include
get_combined_slf_deaths_lookup_pathinto Denodo intermediate output list. @OluwatobiOni, could you please have a look? Thanks